Bug in TScrollBar [Solved]

Bug in TScrollBar [Solved]

Postby Enrico Maria Giordano » Wed Mar 11, 2009 12:08 pm

The following methods of TScrollBar should modified as below:

Code: Select all  Expand view
  METHOD PageUp() INLINE  ::SetPos( ::GetPos() - ::nPgStep ),;
                           If( ::bPageUp != nil, Eval( ::bPageUp ),)

   METHOD PageDown() INLINE  ::SetPos( ::GetPos() + ::nPgStep ),;
                             If( ::bPageDown != nil, Eval( ::bPageDown ),)


The reason is that they are currently different from the other similar method: they set the new position after evaluating the codeblock. With my change they act as the other methods (GoUp(), etc.).

EMG
User avatar
Enrico Maria Giordano
 
Posts: 8243
Joined: Thu Oct 06, 2005 8:17 pm
Location: Roma - Italia

Re: Bug in TScrollBar

Postby Antonio Linares » Sat Mar 14, 2009 9:44 am

Enrico,

I wonder if we will break backwards compatibility with such change.

Also, if the scrollbar position is changed from those codeblocks, then the scrollbar will not be updated.

I am not against such change. Just thinking about possible side effects...
regards, saludos

Antonio Linares
www.fivetechsoft.com
User avatar
Antonio Linares
Site Admin
 
Posts: 41206
Joined: Thu Oct 06, 2005 5:47 pm
Location: Spain

Re: Bug in TScrollBar

Postby Enrico Maria Giordano » Sat Mar 14, 2009 11:01 am

Yes, but the other codeblocks are already reversed, If I'm not wrong.

EMG
User avatar
Enrico Maria Giordano
 
Posts: 8243
Joined: Thu Oct 06, 2005 8:17 pm
Location: Roma - Italia


Return to Bugs report & fixes / Informe de errores y arreglos

Who is online

Users browsing this forum: No registered users and 2 guests