XBROWSE BUGS?

[byte-one]

1.) When MARQSTYLE_HIGHLROW, then on a database with many cols, not all cols are shown. The range from the Hscroll are OK and is also show ok! This bug are not, when bClrRowFocus is defined!!

2.) When scrolling the database, the arrow and the key "DOWN" from the vertical scrollbar has no reaction. Thumbpos are right.

3.) Method ToExcel:
When the value from first col is empty, then the value from following cols are beginning on the first col!
Also I get an error on the first call after starting the computer from this method (TOLEAuto():New( "Excel.Application" )).

Any suggestion?

[byte-one]

ANTONIO, please change this code in XBROWSE.

3.) Method ToExcel:
When the value from first col is empty, then the value from following cols are beginning on the first col! Also, if CRLFs in text (M-fields) should converted with strtran to " ; " or an other character!

This could be a way:

Code: Select all  Expand view

METHOD ClpRow( lFullRow ) CLASS TXBrowse

   local nLast := Len( ::aCols )
   local n, RetVal := ""

   DEFAULT lFullRow := ( ::nMarqueeStyle >= 4 )

   if lFullRow
      for n := 1 to nLast
         if ! ::aCols[ n ]:lHide
*            if ! Empty( RetVal )
*               RetVal   += Chr( 9 )
*            endif
            RetVal += strtran(::aCols[ n ]:ClpText,CRLF," ; ") + Chr( 9 ) //changed byte-one
         endif
      next
   else
      RetVal   := strtran(::SelectedCol():ClpText,CRLF," ; ")
   endif

return RetVal

2.) When scrolling the database, the arrow and the key "DOWN" from the vertical scrollbar has no reaction. Thumbpos are right.

The ::bBof and ::bEof should redefined and not in DEFAULT! I define the xbrowse without any datatype and later i will set the datas with setRDD. But in method initiate() this codeblocks set to .T. (also eof and bof is .T.) when no datatype are defined!

Code: Select all  Expand view

METHOD SetRDD() class TXBROWSE
.
.
  DEFAULT ::bGoTop    := {|| ( ::cAlias )->( DbGoTop() ) },;
           ::bGoBottom := {|| ( ::cAlias )->( DbGoBottom() ) },;
           ::bSkip     := {| n | iif( n == nil, n := 1, ), ( ::cAlias )->( DbSkipper( n ) ) },;
           ::bBookMark := {| n | iif( n == nil,;
                                     ( ::cAlias )->( RecNo() ),;
                                     ( ::cAlias )->( DbGoto( n );
                                    ) ) }

          ::bBof      := {|| ( ::cAlias )->( Bof() ) }   //added byte-one
          ::bEof      := {|| ( ::cAlias )->( Eof() ) }   //added byte-one
.
.


[byte-one]

Antonio, have you seen this points and also my private mail with other things to correcting.

Another issue:
In XBROWSE method toexcel the decimal-point with european "," are only shown, if the value > 1000.
And is it possible, write numeric datatype in oxbrw:toexcel()

[byte-one]

Antonio, have you seen this points and the mail?

[Antonio Linares]

Günther,

We are going to publish a new xbrowse version in just some days.

Our plan is to include your changes and required fixes into it, plus our own changes and enhancements.

[byte-one]

Thanks Antonio!

[PatrickWeisser]

Hello Günther,

Antonio may have fixed this by now, but the code correction I made for the ToExcel() problem that happens when the first xBrowse() column is blank is:

Code: Select all  Expand view

METHOD ClpRow( lFullRow ) CLASS TXBrowse

   local nLast := Len( ::aCols )
   local n, RetVal := ""

   DEFAULT lFullRow := ( ::nMarqueeStyle >= 4 )

   if lFullRow
      for n := 1 to nLast
         if ! ::aCols[ n ]:lHide
            RetVal += ::aCols[ n ]:ClpText  // 02/08/09, Patrick Weisser, moved up.
            if n < nLast                    // 02/08/09, Patrick Weisser, changed from: ! Empty( RetVal )
               RetVal += Chr( 9 )
            endif
         endif
      next
   else
      RetVal   := ::SelectedCol():ClpText
   endif

return RetVal



I was also getting a crash when the ToExcel() feature was used on a machine that did not have Excel installed. I'm using plain Harbour (not xHarbour) and there was no Try/Catch sequence for that case. I made the following change in the ToExcel() method:

Code: Select all  Expand view


#ifdef __XHARBOUR__

   TRY
      oExcel   := GetActiveObject( "Excel.Application" )
   CATCH
      TRY
         oExcel   := CreateObject( "Excel.Application" )
      CATCH
         MsgAlert( "Excel not installed" )
         return Self
      END
   END

#else
   TRY

      oExcel   := TOLEAuto():New( "Excel.Application" )

   CATCH

      MsgAlert( "Excel is not installed." )

      Return( NIL )

   END
#endif



[byte-one]

Hello Patrick,
yes the last chr(9) are not necessary but on the last col anyhow a CRLF is given and the next full line are reading.
And you are not made the strtran() to transform CRLFs to " ; " (Memofields). If not, this makes problems!

The TRY - CATCH is super!

[Antonio Linares]

Patrick,

You can also have TRY ... CATCH in Harbour this way:

Code: Select all  Expand view

#ifndef __XHARBOUR__
   #xcommand TRY      => bError := errorBlock( {|oErr| break( oErr ) } ) ;;
                                 BEGIN SEQUENCE
   #xcommand CATCH [<!oErr!>] => errorBlock( bError ) ;;
                                 RECOVER [USING <oErr>] <-oErr-> ;;
                                 errorBlock( bError )
#endif
static bError