several minor bugs FWH 13.07

[lucasdebeltran]

Hello,

I have discovered several bugs:

report.prg:

in method actívate, the dialog does not show the page number, I see the dialog with title and Cancel button, nothing else. To see it, you need a large dbf.


rpreview.prg:

when you click on Factor combobox, nothing is changed.

Also, cTitles for Msg*** functions are not translated,



prv2pdf.prg:
DEFAULT lOpen := MsgYesNo( FWString( "View" ) + ' ' + cPDF + " (Y/N)?" )

(Y/N) should also be translated, and removed last ? as in Spanish, French or Italian woudl be ¿...?.

And when the report is a Little big, a GPF with hb_out.log happens:

Code: Select all  Expand view

Error irrecuperable 9006: hb_xgrab no puede asignar memoria
Called from DIBTOSTR(0)
Called from EMF2JPEG(74) in .\source\function\PRV2PDF.PRG
Called from FWPDF:ADDMETA(139) in .\source\function\PRV2PDF.PRG
Called from (b)FWSAVEPREVIEWTOPDF(38) in .\source\function\PRV2PDF.PRG
Called from AEVAL(0)
Called from FWSAVEPREVIEWTOPDF(38) in .\source\function\PRV2PDF.PRG
Called from TPREVIEW:SAVEAS(1656) in .\source\classes\RPREVIEW.PRG
Called from (b)TPREVIEW_SAVEASMENU(1617) in .\source\classes\RPREVIEW.PRG
Called from TMENU:ACTIVATE(496) in .\source\classes\MENU.PRG
Called from TBTNBMP:SHOWPOPUP(1494) in .\source\classes\BTNBMP.PRG
Called from (b)TPREVIEW_BUILDBUTTONBAR(334) in .\source\classes\RPREVIEW.PRG
Called from TBTNBMP:CLICK(471) in .\source\classes\BTNBMP.PRG
Called from TBTNBMP:LBUTTONUP(659) in .\source\classes\BTNBMP.PRG
Called from TCONTROL:HANDLEEVENT(1719) in .\source\classes\CONTROL.PRG
Called from TBTNBMP:HANDLEEVENT(1465) in .\source\classes\BTNBMP.PRG
Called from _FWH(3183) in .\source\classes\WINDOW.PRG
Called from SYSREFRESH(0)
Called from STOPUNTIL(60) in .\source\function\MSGRUN.PRG
Called from TPREVIEW:ACTIVATE(143) in .\source\classes\RPREVIEW.PRG
Called from RPREVIEW(1755) in .\source\classes\RPREVIEW.PRG
Called from (b)TREPORT_NEW(173) in .\source\report.prg
Called from TREPORT:ACTIVATE(851) in .\source\report.prg
 

Thank you. Best regards

[lucasdebeltran]

Up.

Thanks.

[Antonio Linares]

Lucas,

We have seen your post and we are working to fix them, thanks

They are minor bugs, as a bug is an error that blocks an application so it can't be used.

[Antonio Linares]

Lucas,

1. In source\classes\report.prg replace:

@ 200, 250 SAY oPagina VAR ::nPage OF ::oRptWnd PIXEL

with this:

@ 35, 90 SAY oPagina VAR ::nPage OF ::oRptWnd PIXEL SIZE 80, 12

[elvira]

Master Antonio,

Please, do not mistreat such errors.

Users see that failures in the application and they think the aplication it´s not safe and secure. Very very important.

Best wishes,

[Antonio Linares]

2. The combobox factor is not intendeed to do "anything" except to set the zoom factor for next zoom.

In case that we want to have certain functionality, this could help:

Code: Select all  Expand view

  @ nRow - 4, nCol + 40 COMBOBOX ::oFactor VAR ::nZFactor ;
      ITEMS { "1", "2", "3", "4", "5", "6", "7", "8", "9" } ;
      OF ::oBar FONT ::oFont PIXEL SIZE 35,200 ;
      ON CHANGE ( oThis:SetFactor( oThis:nZFactor ), oThis:SetOrg1( 0, 0 ) )
 

But the problem is that we can not switch from a zoom factor to another zoom factor.

I appreciate your (all) comments, thanks

[Antonio Linares]

3. done, thanks

[Antonio Linares]

4. done, thanks

[lucasdebeltran]

Antonio,

in 1), report, METHOD Activate

In the dialog is also missing the string "Preparando página: "

Thanks.

[elvira]

Antonio,

Lo del Factor del rpreview.prg nos lo arreglaste así en el método Setfactor de rpreview.prg

::oMeta1:SetZoomFactor( ::nZFactor, ::nZFactor * 2 )

if !::lZoom .and. ! lInit
::Zoom( .T. ) // A.L. 08 Oct 2007
endif
if ::lZoom
::oWnd:oVScroll:SetRange( 1, VSCROLL_RANGE )
if ::nZFactor > 1
::oWnd:oHScroll:SetRange( 1, HSCROLL_RANGE )
else


Con ese código, si pinchas en el combobox o en el menú y cambias el Factor sí que funciona.

[Antonio Linares]

Elvira,

gracias!