Bug in TGraph

[Enrico Maria Giordano]

This is a sample:

Code: Select all  Expand view

#include "Fivewin.ch"


FUNCTION MAIN()

    LOCAL oWnd

    DEFINE WINDOW oWnd

    ACTIVATE WINDOW oWnd;
             ON INIT TEST()

    RETURN NIL


STATIC FUNCTION TEST()

    LOCAL oPrn, oGraph

    PRNLANDSCAPE()

    PRINT oPrn NAME "Test" PREVIEW
        PAGE
            oGraph = TGraph():New()

            oGraph:lXGrid = .T.
            oGraph:lYGrid = .T.

            oGraph:lDotted  = .F.
            oGraph:lTitle   = .T.
            oGraph:lLegends = .F.

            oGraph:cTitle = "TEST"

            oGraph:nBarSep = 100

            oGraph:lxVal = .T.
            oGraph:lViewVal = .T.

            oGraph:cTitX = "TESTX"
            oGraph:cTitY = "TESTY"

            oGraph:aSeries = { { "", RGB( 109, 177, 124 ), 1, .F. } }

            oGraph:aYVals = {}
            oGraph:aData = { {} }

            AADD( oGraph:aYVals, "2016" )
            AADD( oGraph:aData[ 1 ], 100 )

            oGraph:Print( oPrn, 5 * oPrn:nVertRes() / 66, 5 * oPrn:nHorzRes() / 80, 70 * oPrn:nHorzRes() / 80, 56 * oPrn:nVertRes() / 66 )
        ENDPAGE
    ENDPRINT

    PRNPORTRAIT()

    RETURN NIL

I get the following error:

Code: Select all  Expand view

Application
===========
   Path and name: E:\FWXHARB\PEPPE.EXE (32 bits)
   Size: 3,106,816 bytes
   Compiler version: xHarbour 1.2.3 Intl. (SimpLex) (Build 20160815)
   FiveWin  Version: FWHX 16.06
   Windows version: 6.2, Build 9200

   Time from start: 0 hours 0 mins 0 secs
   Error occurred at: 09/26/16, 15:05:55
   Error description: Error BASE/1132  Bound error: array access
   Args:
     [   1] = A   { ... } length: 1
     [   2] = N   2

Stack Calls
===========
   Called from: .\source\classes\TGRAPH.PRG => TGRAPH:PAINT( 1054 )
   Called from: .\source\classes\TGRAPH.PRG => (b)TGRAPH:TGRAPH( 116 )
   Called from:  => TGRAPH:DISPLAY( 0 )
   Called from: .\source\classes\CONTROL.PRG => TGRAPH:HANDLEEVENT( 1697 )
   Called from: .\source\classes\WINDOW.PRG => _FWH( 3305 )
   Called from:  => DIALOGBOXINDIRECT( 0 )
   Called from: .\source\classes\DIALOG.PRG => TDIALOG:ACTIVATE( 296 )
   Called from: .\source\function\ERRSYSW.PRG => ERRORDIALOG( 421 )
   Called from: .\source\function\ERRSYSW.PRG => (b)ERRORSYS( 23 )
   Called from: .\source\classes\TGRAPH.PRG => TGRAPH:PAINT( 1054 )
   Called from: .\source\classes\TGRAPH.PRG => TGRAPH:PRINT( 1782 )
   Called from: PEPPE.prg => TEST( 51 )
   Called from: PEPPE.prg => (b)MAIN( 11 )
   Called from: .\source\classes\WINDOW.PRG => TWINDOW:ACTIVATE( 1028 )
   Called from: PEPPE.prg => MAIN( 11 )

Changing

oGraph:lViewVal = .T.

to

oGraph:lViewVal = .F.

the error goes away.

Any suggestion?

EMG

[cnavarro]

Enrico, change line 1059

Code: Select all  Expand view

            if ( ::aSeries[ nJ, 5 ] = NIL .OR. ::aSeries[ nJ, 5 ] ) .AND. ::aData[ nJ, nI ] <> NIL
 

with

Code: Select all  Expand view

            if ( ::aSeries[ nJ, 5 ] = NIL .OR. ::aSeries[ nJ, 5] ) .AND. ::aData[ nJ, 1 ] <> NIL
 

[Enrico Maria Giordano]

Thank you. Now I get

Code: Select all  Expand view

Argument error conditional

Sorry, I can't provide a sample.

EMG

[cnavarro]

You previous sample run now OK for me

Try, but, thik this not is the problem

Code: Select all  Expand view

            oGraph:aSeries = { { "Value", RGB( 109, 177, 124 ), 1, .F.,,,, } }
 

[Enrico Maria Giordano]

You previous sample run now OK for me

Yes, but the real code in my app doesn't. Here it is, but it's not compilable, sorry:

Code: Select all  Expand view

STATIC FUNCTION GRAFICO( cTit, aDat )

    LOCAL oPrn, oGraph

    LOCAL i

    PRNLANDSCAPE()

    PRINT oPrn NAME "Fatturato " + LOWER( cTit ) PREVIEW
        PAGE
            oGraph = TGraph():New()

            oGraph:lXGrid = .T.
            oGraph:lYGrid = .T.

            oGraph:lDotted  = .F.
            oGraph:lTitle   = .T.
            oGraph:lLegends = .F.

            oGraph:cTitle = "FATTURATO " + cTit

            oGraph:nBarSep = 100

            oGraph:lxVal = M -> ACS_LEVEL < 3
            oGraph:lViewVal = M -> ACS_LEVEL < 3

            oGraph:cTitX = "FATTURATO"
            oGraph:cTitY = "ANNI"

            oGraph:aSeries = { { "", RGB( 109, 177, 124 ), 1, .F. } }

            oGraph:aYVals = {}
            oGraph:aData = { {} }

            FOR i = 1 TO LEN( aDat )
                AADD( oGraph:aYVals, NTRIM( aDat[ i, 1 ] ) + IF( i > 1, " (" + NTRIM( aDat[ i, 2 ] ) + "%)", "" ) )
                AADD( oGraph:aData[ 1 ], aDat[ i, 3 ] )
            NEXT

            oGraph:Print( oPrn, 5 * oPrn:nVertRes() / 66, 5 * oPrn:nHorzRes() / 80, 70 * oPrn:nHorzRes() / 80, 56 * oPrn:nVertRes() / 66 )
        ENDPAGE
    ENDPRINT

    PRNPORTRAIT()

    RETURN NIL

EMG

[Enrico Maria Giordano]

The error pops up executing this line:

Code: Select all  Expand view

oGraph:Print( oPrn, 5 * oPrn:nVertRes() / 66, 5 * oPrn:nHorzRes() / 80, 70 * oPrn:nHorzRes() / 80, 56 * oPrn:nVertRes() / 66 )

EMG

[cnavarro]

Try:
- Create Graph into Dialog
- After, execute oGraph:Print

[Enrico Maria Giordano]

This doesn't work, even with your fix:

Code: Select all  Expand view

#include "Fivewin.ch"


FUNCTION MAIN()

    LOCAL oDlg

    DEFINE DIALOG oDlg

    ACTIVATE DIALOG oDlg;
             ON INIT TEST()

    RETURN NIL

EMG

[cnavarro]

Look your sample

[Enrico Maria Giordano]

Did you try ma new sample using DIALOG?

EMG

[cnavarro]

It is the same example

Code: Select all  Expand view

#include "Fivewin.ch"


FUNCTION MAIN()

    LOCAL oWnd

    DEFINE WINDOW oWnd PIXEL
    oWnd:nTop     := 10
    oWnd:nLeft    := 10
    oWnd:nWidth   := 600
    oWnd:nHeight  := 600
   
    ACTIVATE WINDOW oWnd;
             ON INIT Test1( TEST( oWnd ) )

    RETURN NIL


STATIC FUNCTION TEST( oWnd )

    LOCAL oGraph

            oGraph = TGraph():New()

            oGraph:lXGrid = .T.
            oGraph:lYGrid = .T.

            oGraph:lDotted  = .F.
            oGraph:lTitle   = .T.
            oGraph:lLegends = .F.

            oGraph:cTitle = "TEST"

            oGraph:nBarSep = 100

            oGraph:lxVal = .T.
            oGraph:lViewVal = .T.

            oGraph:cTitX = "TESTX"
            oGraph:cTitY = "TESTY"

            oGraph:aSeries = { { "Value", RGB( 109, 177, 124 ), 1, .F.,,,, } }

            oGraph:aYVals = {}
            oGraph:aData = { {} }

            AADD( oGraph:aYVals, "2016" )
            AADD( oGraph:aData[ 1 ], 100 )

            oWnd:oClient  := oGraph
           
            //if MsgYesNo( "Print Graph", "Attention:" )
            //   Test1( oGraph )
            //endif
RETURN oGraph

//----------------------------------------------------------------------------//

STATIC FUNCTION TEST1( oGraph )

    LOCAL oPrn

    PRNLANDSCAPE()

    PRINT oPrn NAME "Test" PREVIEW
        PAGE
            oGraph:Print( oPrn, 5 * oPrn:nVertRes() / 66, 5 * oPrn:nHorzRes() / 80, 70 * oPrn:nHorzRes() / 80, 56 * oPrn:nVertRes() / 66 )
        ENDPAGE
    ENDPRINT

    PRNPORTRAIT()

RETURN NIL

//----------------------------------------------------------------------------//

 

[Enrico Maria Giordano]

This is the sample that doesn't work:

Code: Select all  Expand view

#include "Fivewin.ch"


FUNCTION MAIN()

    LOCAL oDlg

    DEFINE DIALOG oDlg

    ACTIVATE DIALOG oDlg;
             ON INIT TEST()

    RETURN NIL


STATIC FUNCTION TEST()

    LOCAL oPrn, oGraph

    PRNLANDSCAPE()

    PRINT oPrn NAME "Test" PREVIEW
        PAGE
            oGraph = TGraph():New()

            oGraph:lXGrid = .T.
            oGraph:lYGrid = .T.

            oGraph:lDotted  = .F.
            oGraph:lTitle   = .T.
            oGraph:lLegends = .F.

            oGraph:cTitle = "TEST"

            oGraph:nBarSep = 100

            oGraph:lxVal = .T.
            oGraph:lViewVal = .T.

            oGraph:cTitX = "TESTX"
            oGraph:cTitY = "TESTY"

            oGraph:aSeries = { { "", RGB( 109, 177, 124 ), 1, .F. } }

            oGraph:aYVals = {}
            oGraph:aData = { {} }

            AADD( oGraph:aYVals, "2016" )
            AADD( oGraph:aData[ 1 ], 100 )

            oGraph:Print( oPrn, 5 * oPrn:nVertRes() / 66, 5 * oPrn:nHorzRes() / 80, 70 * oPrn:nHorzRes() / 80, 56 * oPrn:nVertRes() / 66 )
        ENDPAGE
    ENDPRINT

    PRNPORTRAIT()

    RETURN NIL

EMG

[Enrico Maria Giordano]

The error is in the line

Code: Select all  Expand view

::oWnd:ReleaseDC()

inside the Print() method.

EMG

[Enrico Maria Giordano]

Another problem in Paint() method:

::aSeries[nJ,5]

contains NIL.

EMG

[Enrico Maria Giordano]

Works fine if

Code: Select all  Expand view

oGraph:aSeries = { { "", RGB( 109, 177, 124 ), 1, .F. } }

is replaced with

Code: Select all  Expand view

oGraph:aSeries = { { "", RGB( 109, 177, 124 ), 1, .F., .T. } }

It seems that the fifth item of aSeries lost its default value (previously it had one, don't know since which FWH release).

Anyway, problem solved for me. But a proper fix would be welcome.

EMG