Printer hDC is 0

[hua]

I sub-classed TPrinter as XPrinter and called it like this.
(cPrinter is the name of the printer to use. Selected by user via PrinterSetup() and saved to a text file.)

Code: Select all  Expand view

XPRINTER oPrn PREVIEW MODAL NAME cRptTitle to cPrinter

This code works with my old version of FWH11.08.
With FWH1912+Harbour, if I set printer to "Microsoft Print To Pdf", it will generate error because hDC is 0.

When I compare TPrinter:new() between the FWH1108 and FWH1912 versions, the difference is the usage of PrinterDcFromName() in FWH1912

Code: Select all  Expand view

   // FWH1912
   if lUser
      ::hDC := GetPrintDC( GetActiveWindow(), lSelection, PrnGetPagNums() )
      if ::hDC != 0
         cModel = ::GetModel() + "," + ::GetDriver() + "," + ::GetPort()
      endif
   elseif cModel == nil
      ::hDC  := GetPrintDefault( GetActiveWindow() )
      if ::hDC != 0
         cModel = ::GetModel() + "," + ::GetDriver() + "," + ::GetPort()
      endif
   else
      ::hDC = PrinterDcFromName( , cModel, )
   endif

Code: Select all  Expand view

   //FWH1108
   if lUser
      ::hDC := GetPrintDC( GetActiveWindow(), lSelection, PrnGetPagNums() )
      if ::hDC != 0
         cModel = ::GetModel() + "," + ::GetDriver() + "," + ::GetPort()
      endif
   elseif cModel == nil
      ::hDC  := GetPrintDefault( GetActiveWindow() )
      if ::hDC != 0
         cModel = ::GetModel() + "," + ::GetDriver() + "," + ::GetPort()
      endif
   else
      cPrinter := GetProfString( "windows", "device" , "" )
      WriteProfString( "windows", "device", cModel )
      SysRefresh()
      PrinterInit()
      ::hDC := GetPrintDefault( GetActiveWindow() )
      SysRefresh()
      WriteProfString( "windows", "device", cPrinter  )
      // PrinterInit()
      // DeleteDC( ::hDC )
      // ::hDC = PrinterDCfromName( cModel )
   endif
 

I tested replacing PrinterDcFromName( , cModel, ) with the old code and it works.

So what is the accurate solution? I don't want to have to manually linked-in a fixed version of TPrinter.

TIA

[Enrico Maria Giordano]

This is how i am using it:

Code: Select all  Expand view

::hDC = PRINTERDCFROMNAME( STRTOKEN( GETPROFSTRING( "Devices", cModel, "" ), 1, "," ), cModel, STRTOKEN( GETPROFSTRING( "Devices", cModel, "" ), 2, "," ) )

[karinha]

https://forums.fivetechsupport.com/viewtopic.php?f=3&t=14730&start=0

https://forums.fivetechsupport.com/viewtopic.php?f=6&t=28305

https://forums.fivetechsupport.com/viewtopic.php?f=6&t=27598&start=0

Regards, saludos.

[hua]

Thanks Enrico.
Does this mean you maintain your own amended version of printer.prg?

This is how i am using it:

Code: Select all  Expand view

::hDC = PRINTERDCFROMNAME( STRTOKEN( GETPROFSTRING( "Devices", cModel, "" ), 1, "," ), cModel, STRTOKEN( GETPROFSTRING( "Devices", cModel, "" ), 2, "," ) )

[hua]

Thanks for the leads Karinha

https://forums.fivetechsupport.com/viewtopic.php?f=3&t=14730&start=0

https://forums.fivetechsupport.com/viewtopic.php?f=6&t=28305

https://forums.fivetechsupport.com/viewtopic.php?f=6&t=27598&start=0

Regards, saludos.

[hua]

Just to update.

Enrico's post prompts me to eventually inspect var cModel value in my sub-class of TPrinter.
To my surprise, it wasn't just a string of printer name but includes the driver and port too.

In old PrintBegin(), the code at the end was

Code: Select all  Expand view

 
   ...
   cText   := GetProfString( "Devices", aPrn[ nScan ] )
   cDevice := aPrn[ nScan ] + "," + cText

return oPrinter := TPrinter():New( cDoc, .f., lPreview, cDevice, lModal, lSelection )
 

In FWH1912 it is

Code: Select all  Expand view

...
return oPrinter := TPrinter():New( cDoc, .f., lPreview, aPrn[ nScan ], lModal, lSelection, cFile )

After I update my PrintBegin() equivalent in my sub-class, no more error

[Enrico Maria Giordano]

Thanks Enrico.
Does this mean you maintain your own amended version of printer.prg?

Yes, I have some classes that I rewrote to adapt them to my own purposes.