bug in FW 13.04 combobox

[ADutheil]

testcombo.prg not working the same way between 13.03 and 13.04. If you initialize cItem local cItem := "Testing" it is shown with 13.03 and not with 13.04.

[Antonio Linares]

André,

I email you the fixed library

[ADutheil]

Ok now working with BCC582. Can you send me the libs for msvc10 or better teach how to remove and add a prg from the libs like in the old days lib -+ ...

[Mulyadi]

Antonio...

I have same problem. Advisable your posting the fix here..
but in my case, in RC file I must be change all combobox elements..
is so very very very very very back breaking....
TQ.


Mulyadi

[byte-one]

Antonio, in my code it is beeing enough to write directly in the code "REDEFINE COMBOBOX....STYLE CBS_DROPDOWN". The RC-file must not be changed.

[Antonio Linares]

André,

This is how I manage the libraries with Microsoft:

set VCDIR="%ProgramFiles%\Microsoft Visual Studio 10.0\VC"

%VCDIR%\bin\Lib Fivehc32.lib /OUT:Fivehc32.lib module.obj

[Antonio Linares]

Mulyadi,

have you tested the fix that I have published above ?

If keeps failing, could you please post a portion of your RC where you use the comboboxes and what you have to change ? thanks

[Antonio Linares]

Günther,

FWH COMBOBOX command also supports that clause

Could you please show an example of what is failing with current combobox implementation ? Here is fine on our tests, thanks

[ADutheil]

Antonio,

I just perceived I don´t have the new combobox.prg. Can you mail it please?

[Antonio Linares]

Already sent

[byte-one]

Antonio, now the reaction seems to be OK!

Additional i had moved the creation from the ::oGet and ::oGet:bLostFocus and ::oGet:bKeyChar in ::initiate(). So this code are required only once. (not separate in ::new() and ::redefine() ) -> see code down
Only the function in ::GetKeyChar( nKey ) to seek in the list are not optimal. When no item found, strange things are to see. (double chars, ...)

Code: Select all  Expand view

METHOD Initiate( hDlg ) CLASS TComboBox

   ::Super:Initiate( hDlg )

   ::Default()

   if nAnd( GetWindowLong( ::hWnd, GWL_STYLE ), CBS_DROPDOWNLIST ) == CBS_DROPDOWN
      ::oGet := TGet():ReDefine( nil,    ;  // ID not used
                              ::bSetGet, ;  // bSETGET(uVar)
                              Self,      ;  // oDlg
                              ::nHelpID, ;  // Help Context ID
                              ::cPict,     ;  // Picture
                              nil,       ;  // Valid is handled by the CBx
                              ::nClrText,;
                              ::nClrPane,;
                              ::oFont,   ;  // <oFont>
                              nil,       ;  // <oCursor>
                              ::cMsg,      ;  // cMsg
                              nil,       ;  // <.update.>
                              nil,       ;  // <{uWhen}>
                              ::bEChange,  ;  // {|nKey,nFlags,Self| <uEChange>}
                              .F.        )  // <.readonly.> )

      ::oGet:hWnd = GetWindow( ::hWnd, GW_CHILD )
      ::oGet:Link()
      ::oGet:bLostFocus = ;
      {| hCtlFocus, nAt, cItem| cItem := GetWindowText( ::hWnd ), ;
      nAt := ::SendMsg( CB_FINDSTRING, 0, Trim( cItem )) + 1,;
      Eval( ::bSetGet, cItem ),;
      ::Select( nAt ),;
      SetWindowText( ::hWnd, cItem ),;
      If( ::bValid != nil .and. ;
      GetParent( hCtlFocus ) == GetParent( ::hWnd ),;
      If( ! Eval( ::bValid, ::oGet, Self ),;
      ::PostMsg( WM_SETFOCUS ),),) }

      ::oGet:bKeyChar = { | nKey | ::GetKeyChar( nKey ) }
    endif
   ::Refresh()
return nil

[Antonio Linares]

Günther,

Additional i had moved the creation from the ::oGet and ::oGet:bLostFocus and ::oGet:bKeyChar in ::initiate()

We can't do that or we break existing legacy code, like this:

REDEFINE COMBOBOX oCbx ...

oCbx:oGet:... = ... // Your changes will error here!

ACTIVATE DIALOG oDlg

[byte-one]

Ok Antonio. General: On what moment the ::initiate() from the controls are called and from what code?

[Antonio Linares]

Günther,

Method Initiate() is invoked in response to Windows WM_INITDIALOG message:

http://msdn.microsoft.com/en-us/library/windows/desktop/ms645428(v=vs.85).aspx

So it is executed from ACTIVATE DIALOG but _before_ the dialog is shown

Sent to the dialog box procedure immediately before a dialog box is displayed

[byte-one]

Antonio, thanks!