Page 2 of 2

Re: aGetfiles bug

PostPosted: Wed Feb 13, 2019 12:10 pm
by byte-one
Ok, to test it, i require the function fw_wcslen()! Can somebody send me or show the place in source?

Re: aGetfiles bug

PostPosted: Wed Feb 13, 2019 4:39 pm
by Giovany Vecchi
The problem is not in bytes, but in query length.
Example: If you select 60 files that are in the c: \ temp folder, it would look like this:
"c: \ temp \ archi01.txt" "c: \ temp \ archi02.txt" etc etc.
Each file would take 21 len characters ("'c: \ temp \ archi01.txt'") = 21
If the folder is of greater length Ex: c: \ My documents secrets, it would look like this:
"c: \ My documents secrets \ archi01.txt"
len ('"c: \ My documents secrets \ archi01.txt"') = 37

So if you put a higher value in:
pFile = fw_parWideLen (8, 65534); // 65534 would be the limit of 16 bits, I did not test greater than this value.

The return of the characters composition arranged in windows api will be treated with more space.

I did not go deep to study certainly what causes the error. I know I solved it this way.

Re: aGetfiles bug

PostPosted: Wed Feb 13, 2019 4:47 pm
by Antonio Linares
Günther,

Code: Select all  Expand view
size_t fw_wcslen( const wchar_t * s )
{
   const wchar_t *p;

   p = s;
   while (*p)
      p++;

   return p - s;
}

Re: aGetfiles bug

PostPosted: Mon Mar 04, 2019 8:47 am
by byte-one
Antonio, now a have increased #define SIZE_IN_BYTES 153840
But that is not all. In HB_FUNC( CGETFILE ) i made this changes:
Code: Select all  Expand view
…...
    pDir        = fw_parWideLen( 4, 512 );
    wLen    = ( ( dwFlags & OFN_ALLOWMULTISELECT ) ? SIZE_IN_BYTES : 512 );   //reactivate
    pFile       = fw_parWideLen( 8, wLen );   //change
    pFilter = fw_parWideLen( 1, 800 );
    pText = ( LPSTR ) pFilter;
    for ( w = 0; w < 800; w++ )
…...
   ofn.nMaxFile        = wLen;     //change
…...

Re: aGetfiles bug

PostPosted: Mon Mar 04, 2019 9:20 am
by Antonio Linares
Günther,

Is it working fine now ?

Many thanks for your great feedback :-)

Re: aGetfiles bug

PostPosted: Mon Mar 04, 2019 10:31 am
by byte-one
I now can get many files ( 300 i have tested)!

Re: aGetfiles bug

PostPosted: Mon Mar 04, 2019 11:10 am
by Antonio Linares
Please email me your modified file, thanks!

Re: aGetfiles bug

PostPosted: Mon Mar 04, 2019 12:06 pm
by byte-one
Antonio, sent!

Re: aGetfiles bug

PostPosted: Mon Apr 08, 2019 2:05 pm
by byte-one
Antonio, is this included in new version?

Re: aGetfiles bug

PostPosted: Mon Apr 08, 2019 2:44 pm
by Antonio Linares
Günther,

No, it is not included yet. I am checking why it has not been included yet.

Please email it to me again, thanks

Re: aGetfiles bug

PostPosted: Tue Apr 09, 2019 4:55 am
by Antonio Linares
We found your email and we are implementing it.

many thanks for the reminder

Re: aGetfiles bug

PostPosted: Tue Jul 09, 2019 8:21 pm
by Ariel
Antonio,

no te olvides de incluir esto ya que a mi tmb me casca.

Gracias.!

Re: aGetfiles bug

PostPosted: Wed Jul 10, 2019 12:40 pm
by byte-one
Please, what in english?