ADO RDD xHarbour

[AHF]

Lucas,

Seek with lSoftseek lLastfind and locate tested. Work.

Seek like dbf is never used unless seek expression corresponds to more than 1 field because we cannt use find.
In this case we use select
Otherwise we use find.

Bookmark its only used in ado_recno to save position.

Seems the array doesnt follow specs please check in adordd for index array
Format is:

{ { tablename, {indexnamea,indexexp}, {indexname2, indexexp} },;
{nexttablename, {nextindexname, indexexp} } }

[lucasdebeltran]

Antonio,

Yes, I follow that structure:

Code: Select all  Expand view

LOCAL   Alista_fic:= { { "LIBROS", {"LIBROS1", "TITULO"} }  }

[AHF]

Lucas,

Please place in top ORDLSTFOCUS:

msgselect(aWAData[WA_INDEXES])
msginfo(aWAData[WA_INDEXACTIVE])

what values do you get?

[lucasdebeltran]

Hello,

xbrowse(aWAData[WA_INDEXES])

Is empty.


msginfo(aWAData[WA_INDEXACTIVE])

Gives 0.

Thank you

[AHF]

Lucas,

Did you open the indexes with set index to or ordlistadd.

They are not opened with the table by adordd

They must be opened before ordsetfocus gets called
This is not the normal procedure with ordsetfocus that does nothing if the index

Its a guess

[AHF]

New adordd with relations and transactions https://github.com/AHFERREIRA/adordd.git

[lucasdebeltran]

Antonio,

No, I didn´t use SET INDEX. Now it Work:

Code: Select all  Expand view

SET INDEX TO LUCAS1, LUCAS2

But there is a bug at OrdSetFocus(). It returns numbers, but it should return the tag name, i.e. LUCAS2.

For example:

Code: Select all  Expand view

LUCAS->(  OrdSetFocus("MYLUCASBIS")  )

Alert(OrdSetFocus()) shoud return MYLUCASBIS, not a number.


 

Thank you.

[AHF]

Lucas,

You re right! Corrected.

Could you please try the following :

dbseek with and without softseek expression = 1 indexkey and expression = 2 or more index keys

set relation and check how is performance.

Locking - Please remember that locks are virtual and arent placed in the files so in fact dont protect others from writing the locked file / record.
This is assured by transactions (new change from last adordd)

Locking only give us the records lock array to allow us to go back to the locks records wihtout disrupt the converted application logic.
First lock everything needs to an update then loop through the lock arrray and replace.
After unlock everything.

Transactions . begintrans with the 1st locks and endtrans with the 1st dbcommit.
For our app logic this works.

Are you coding (all code) in this way?
Is xBrowse running already?

Thanks

[lucasdebeltran]

Antonio,

Can you send me the fix for indexes?. Also, have you received my email from yesterday?.

Also, for Harbour users, please add the following code:

at the top of adorrd.prg:

Code: Select all  Expand view

#ifndef __XHARBOUR__

   #include "fivewin.ch"        // as Harbour does not have TRY / CATCH
   #define UR_FI_FLAGS           6
   #define UR_FI_STEP            7
   #define UR_FI_SIZE            5 // by Lucas for Harbour


#endif


ANNOUNCE ADORDD

//THREAD
STATIC t_cTableName
//THREAD

At ado_open():

Code: Select all  Expand view

 FOR n := 1 TO nTotalFields
 
       aField := Array( UR_FI_SIZE )
       aField[ UR_FI_NAME ] := oRecordSet:Fields( n - 1 ):Name
       aField[ UR_FI_TYPE ]    := ADO_FIELDSTRUCT( oRecordSet, n-1 )[7]
       aField[ UR_FI_TYPEEXT ] := 0
       aField[ UR_FI_LEN ]     := ADO_FIELDSTRUCT( oRecordSet, n-1 )[3]
       aField[ UR_FI_DEC ]     := ADO_FIELDSTRUCT( oRecordSet, n-1 )[4]
 
  #ifdef __XHARBOUR__
      aField[ UR_FI_FLAGS ] := 0  // xHarbour expecs this field
      aField[ UR_FI_STEP ] := 0 // xHarbour expecs this field
 #endif
 
      UR_SUPER_ADDFIELD( nWA, aField )
   NEXT

   nResult := UR_SUPER_OPEN( nWA, aOpenInfo )
 

at ADO_INFO()

Code: Select all  Expand view

    CASE uInfoType == DBI_FULLPATH // 10  /* The Full path to the data file      */

         //MSGINFO("IN SQL FULL PATH DOES NOT MATTER!")
         uReturn := ""
 

at ado_append(), remove oRecordSet:Update().


Thank you.

[AHF]

Lucas,

I just saw your email but couldnt open prg extensions so please send next time with txt extension.

Im finnishing all changes and I l post new version asap.

Thanks

[AHF]

Posted new version https://github.com/AHFERREIRA/adordd.git

[lucasdebeltran]

Antonio,

Thanks. Resent the email.

Now it works fine with Browse() and OrdSetFocus(), but not with xBrowse().

With xBrowse() I get:

Error description: Error BASE/1074 Error de argumento: <=
Args:
[ 1] = C LIBROS1
[ 2] = N 2

Stack Calls
===========
Called from: lucas2.prg => ADO_ORDINFO( 824 )
Called from: => ORDBAGNAME( 0 )
Called from: .\source\classes\XBROWSE.PRG => TXBROWSE:SETRDD( 4140 )
Called from: .\source\classes\XBROWSE.PRG => XBRWSETDATASOURCE( 13030 )
Called from: .\source\function\XBROWSER.PRG => XBROWSE( 112 )
Called from: lucas2.prg => MAIN( 87 )



ADO_ORDINFO( 824 ) is:

Code: Select all  Expand view

  CASE nIndex == DBOI_BAGNAME

        IF ! Empty( aWAData[ WA_INDEXES ] ) .AND. ! Empty( aOrderInfo[ UR_ORI_TAG ] ) .AND. ;
            aOrderInfo[ UR_ORI_TAG ] <= LEN(aWAData[ WA_INDEXES ])

last line.



\source\classes\XBROWSE.PRG => TXBROWSE:SETRDD( 4140 )

Code: Select all  Expand view

        ::aCols[ nFor ]:cOrdBag       := ( cAlias )->( OrdBagName( ::aCols[ nFor ]:cSortOrder ) )

Seems that same change applied to OrdSetFocus() should be done to OrdBagName()?.

Thank you.

[AHF]

Ok it can receive either numeric order or name order.

Done https://github.com/AHFERREIRA/adordd.git

I ve made some changes Relations are not working anymore will revert soon.

[lucasdebeltran]

Hello Antonio,

Thank you. Now xBrowse() seems to work.

However, some changes are required at adordd.prg:


i) You have ANNOUNCE ADORDD twice on top of it.



ii) Also, at ADO_OPEN() you have to comment out:

/*
aOpenInfo[ UR_OI_NAME ] += ".dbf"

hb_adoSetTable( aOpenInfo[ UR_OI_NAME ] )
hb_adoSetEngine( "")
hb_adoSetServer( "")
hb_adoSetQuery( )
hb_adoSetUser( "")
hb_adoSetPassword( "" )
*/


iii) And:

// aWAData[ WA_TABLENAME ] := SUBSTR(CFILENOPATH(aWAData[ WA_TABLENAME ] ),1,LEN(CFILENOPATH(aWAData[ WA_TABLENAME ] ))-4)



iv) Browses requiere mandatory at ADO_OPEN() :

oRecordSet:CursorLocation := adUseClient //its slower but has avntages such always bookmaks
oRecordSet:LockType := adLockOptimistic


Thank you.

[lucasdebeltran]

Antonio,

In the LOCATE FOR command, it does not suport those ways:

LOCATE FOR FIELD->NAME ...

or

LOCATE FOR LUCASTABLE->NAME...

Thank you.