Antonio: Memory Leak in DipWrite

[byte-one]

Antonio, i found, that in this function pDip should released with

Code: Select all  Expand view

hb_xfree( ( char * ) pDib );

on 3 positions. I write 1000 BMPs and then the computer-Memory are full in my case. I searched for the reason and found this.

Code: Select all  Expand view

BOOL DibWrite( LPSTR szFileName, HGLOBAL hDIB )
{

   long lSize;
   char * pDib;
   int hBmp;

   pDib = DibToStr( hDIB, &lSize );

   #ifndef UNICODE
   if( ( hBmp = _lcreat( szFileName, 0 ) ) != HFILE_ERROR )
   {
      _hwrite( hBmp, ( const char * ) pDib, lSize );
      _lclose( hBmp );
      GlobalUnlock( hDIB );
    hb_xfree( ( char * ) pDib );
      return TRUE;
   }
   #else
   if( ( hBmp = hb_fsCreate( ( unsigned char * ) szFileName, 0 ) ) != ( int ) INVALID_HANDLE_VALUE )
   {
      hb_fsWriteLarge( hBmp, ( unsigned char * ) pDib, lSize );
      hb_fsClose( hBmp );
      GlobalUnlock( hDIB );
    hb_xfree( ( char * ) pDib );
      return TRUE;
   }
   #endif
   else
   {
      GlobalUnlock( hDIB );
    hb_xfree( ( char * ) pDib );
      return FALSE;
   }
}

[Antonio Linares]

Günther,

You are totally right. Many thanks!

Included for next FWH build.

[byte-one]

Antonio, all is ok now. Maybe you should check all hb_xalloc() and hb_xgrab() for corresponding hb_xfree(). Specially in C-functions, which returns only a pointer and this pointer are to released in the calling function.

[Antonio Linares]

Günther,

I constantly do it, though sometimes we may miss a case, like this one. thanks,