Antonio: Modifying CLASS TRBtn (Bug?)

[byte-one]

I changed the marked line with NEW as when i change the position of the dialog with ON INIT oDlg:move(....) the horizontally position of the popup-menu follows not the button!

Code: Select all  Expand view

case ::nTypeButton == TYPE_POPUP
                     if nCol >= ::nPopupMargin .or. !lAction
                        oWnd := ::oWnd
                        oWnd:NcMouseMove() // close the tooltip
                        if oWnd:oPopup == nil
                           oWnd:oPopup = ::oPopup
//                           ::oPopup:Activate( ::nTop + ::nHeight(),::nLeft - If( ! oWnd:IsKindOf( "TRBGROUP" ), oWnd:nLeft, 0 ), oWnd, .F. )
                            ::oPopup:Activate( ::nTop + ::nHeight(), ::nLeft , oWnd, .F. )    //NEW!!
 

[James Bott]

I'm not clear, are you saying that the code you posted is the fix for the problem? If so, which PRG, and method is it in?

James

[nageswaragunupudi]

I'm not clear, are you saying that the code you posted is the fix for the problem? If so, which PRG, and method is it in?

James

Yes. That is what he says.
This code is from Method LButtonUp() of trbtn.prg

We are yet to test at our end.

[Antonio Linares]

Günther,

Could you please provide an example to test here ? thanks

[byte-one]

Antonio, if i move the window with ON INIT oWnd:move() also the data oWnd:nLeft are changed! And the comes the

Code: Select all  Expand view

::nLeft - oWnd:nLeft

and the popup-menu are moved left on the display-position.
z.b. Dialog position left is 700 after the move(). This oDlg:nLeft are subtract from the oButton:left !?

Code: Select all  Expand view

::oPopup:Activate( ::nTop + ::nHeight(),;
::nLeft - If( ! oWnd:IsKindOf( "TRBGROUP" ), oWnd:nLeft, 0 ),;   //here are the fault
 oWnd, .F. )

This code are also in

Code: Select all  Expand view

METHOD ShowPopup() CLASS TRBtn

[James Bott]

Günther,

I think Antonio was looking for a small self-contained example program that shows the problem that he can use to test your fix for the problem.

[byte-one]

Antonio, James, here are a small example!

Code: Select all  Expand view

function trb_test()
local oDlg , oBtn , oMenu
MENU oMenu POPUP
    MENUITEM "1" ACTION oDlg:end()
    MENUITEM "End" ACTION oDlg:end()
ENDMENU
DEFINE DIALOG oDlg SIZE 400,200 PIXEL TITLE "RBBTN-Menu-Test"
@ 80,5 RBBTN oBtn OF oDlg POPUP MENU oMenu PROMPT "RBBTN" SIZE 58,13
ACTIVATE DIALOG oDlg ON INIT oDlg:move(200,300)
return NIL

[byte-one]

Antonio, please try to open the popup-menu in the above example and you can see, that the popup-menu are left from the button!

[Enrico Maria Giordano]

Günther,

yes, I confirm the problem.

EMG

[nageswaragunupudi]

Thanks for the help. We are incorporating the fix for the next release.

[Antonio Linares]

Günther, Enrico,

To me this seems the right fix. I appreciate your feedback:

Code: Select all  Expand view

                 case ::nTypeButton == TYPE_POPUP
                     if nCol >= ::nPopupMargin .or. !lAction
                        oWnd := ::oWnd
                        oWnd:NcMouseMove() // close the tooltip

                        // Modified to handle Codeblock as oPopup 2014-10-10
                        if oWnd:oPopup == nil
                           oWnd:oPopup = XEval( ::oPopup, Self )
                           ::CoorsUpdate()                                 
                           oWnd:oPopup:Activate( ::nTop + ::nHeight(),;
                                                 ::nLeft, oWnd, .F. )
 

[nageswaragunupudi]

That's what Mr Günther proposed.

[Antonio Linares]

::CoorsUpdate() was missing

Without it, it fails