Bug in ResizeImg()

[Enrico Maria Giordano]

The result of ResizeImg() is slightly different in width and height if compared with ResizeBmp() and PalBmpDraw().

EMG

[Marco Turco]

Is it related to last FWH build 4 ?

[Enrico Maria Giordano]

Marco,

no, it was there in the previous builds too.

EMG

[Enrico Maria Giordano]

Unfortunately, there is no source code for ResizeImg() so I can't try to fix the problem.

EMG

[Antonio Linares]

Enrico,

I send you its source code by email, thanks

[Enrico Maria Giordano]

Antonio,

thank you. I'll do some experiment with it.

EMG

[Enrico Maria Giordano]

Antonio,

found! Replace

Code: Select all  Expand view  RUN

      iRateW     = ( DOUBLE ) iNewWidth  / ( DOUBLE ) bm.bmWidth  * 100 + 1;
       iRateH     = ( DOUBLE ) iNewHeight / ( DOUBLE ) bm.bmHeight * 100 + 1;
 

with

Code: Select all  Expand view  RUN

      iRateW     = ( DOUBLE ) iNewWidth  / ( DOUBLE ) bm.bmWidth  * 100;
       iRateH     = ( DOUBLE ) iNewHeight / ( DOUBLE ) bm.bmHeight * 100;

EMG

[Enrico Maria Giordano]

I spoke too fast. It GPFs, I don't know why. I continue to experiment...

EMG

[Enrico Maria Giordano]

It seems to work in this form:

Code: Select all  Expand view  RUN

      iRateW     = ( DOUBLE ) iNewWidth  / ( DOUBLE ) bm.bmWidth  * 100 + 0.9;
       iRateH     = ( DOUBLE ) iNewHeight / ( DOUBLE ) bm.bmHeight * 100 + 0.9;

Please check.

EMG

[Antonio Linares]

Enrico,

Could you please provide an example to test it ? thanks

[Enrico Maria Giordano]

Here it is:

Code: Select all  Expand view  RUN

#include "Fivewin.ch"


FUNCTION MAIN()

    TEST( .T. )

    TEST( .F. )

    RETURN NIL


STATIC FUNCTION TEST( lImg )

    LOCAL oDlg

    DEFINE DIALOG oDlg;
           STYLE NOR( WS_POPUP, WS_DLGFRAME, DS_MODALFRAME );
           SIZE 800, 600

    ACTIVATE DIALOG oDlg;
             ON PAINT DRAWIMG( "c:\fwh\bitmaps\magic.bmp", hDC, oDlg:nWidth, oDlg:nHeight, lImg );
             CENTER

    RETURN NIL


STATIC FUNCTION DRAWIMG( cFile, hDC, nWidth, nHeight, lImg )

    LOCAL hImg := LOADIMG( cFile )

    LOCAL hImg2

    IF lImg
        hImg2 = RESIZEIMG( hImg, nWidth, nHeight )
    ELSE
        hImg2 = RESIZEBMP( hImg, nWidth, nHeight )
    ENDIF

    ABPAINT( hDC, 0, 0, hImg2, 255 )

    DELETEOBJECT( hImg2 )
    DELETEOBJECT( hImg )

    RETURN NIL


STATIC FUNCTION LOADIMG( cFile )

    IF !FILE( cFile )
        RETURN 0
    ENDIF

    RETURN GDIP_IMAGEFROMFILE( cFile, .T. )

EMG

[Enrico Maria Giordano]

Another request.

ResizeImg() is a bit slower, probably due to the two nested loops involved. How to speed it up?

EMG

[Antonio Linares]

Enrico,

Do you need to resize the bitmap or simply paint it larger ?

[Enrico Maria Giordano]

Antonio,

yes, paint it larger (or smaller). But ABPaint() doesn't support resize.

EMG

[Antonio Linares]

Enrico,

Not sure if we can speed up the loop