Bugs in TGgiplus

[byte-one]

Antonio, in this context i point to a bug in HB_FUNC( ROUNDRECT ) // hDC, nLeftRect, nTopRect, nRightRect, nBottomRect, nEllipseWidth, nEllipseHeight, hPen )

There are also changed left and top bzw. right and bottom

Code: Select all  Expand view

 BOOL bResult = RoundRect( hDC, hb_parnl( 2 ), hb_parnl( 3 ), hb_parnl( 4 ),
                             hb_parnl( 5 ), hb_parnl( 6 ), hb_parnl( 7 ) )

Should be

Code: Select all  Expand view

 BOOL bResult = RoundRect( hDC, hb_parnl( 3 ), hb_parnl( 2 ), hb_parnl( 5 ),
                             hb_parnl( 4 ), hb_parnl( 6 ), hb_parnl( 7 ) )

Also the documentation is wrong.
Please call rectangle(...) an roundrect(...) with same parameters! Should be same direction and size!

[nageswaragunupudi]

Mr Günther

The existing code exactly matches the syntax given along with the function and also gives the correct results.

Will you please recheck?

Incidentally this is not related to GDI+

[byte-one]

Mr. Rao, not GDI+ but we should follow (as you above said) the FWH-syntax nTop, nLeft ... etc also in normal GDI!?
Please call rectangle(...) an roundrect(...) with same parameters in same order! Should be same direction and size, but is different!

[nageswaragunupudi]

Mr. Rao, not GDI+ but we should follow (as you above said) the FWH-syntax nTop, nLeft ... etc also in normal GDI!?
Please call rectangle(...) an roundrect(...) with same parameters in same order! Should be same direction and size, but is different!

Personally I too like using the same style everywhere including RoundRect. I am with you.

But this function with this syntax has been there for quite long. Not only in other parts of FWH library but in many user applications also this syntax is/ might have been used. Any change at this stage may break existing applications. Hope you understand.

I made the suggestion in the above case because the best time to change is the first time.