TGet bug?

[Enrico Maria Giordano]

In TGet:LButtonUp() method there is

elseif Empty( cText ) .or. cText == " / /" .or. ;
AllTrim( cText ) == "0" .or. ;
AllTrim( cText ) == " - -"

but I think that cText can never be exactly equal to " / /" and surely AllTrim( cText ) can never be exactly equal to " - -".

EMG

[manuramos]

I think it's OK because ALLTRIM(" / / ") is exactly "/ /", in the same way ALLTRIM(" - - ") is exactly "- -", and is necesary.

[Enrico Maria Giordano]

I think it's OK because ALLTRIM(" / / ") is exactly "/ /",

Yes, but the exact comparison is with " / / " (note that it starts with a space).

in the same way ALLTRIM(" - - ") is exactly "- -", and is necesary.

And here the exact comparison is with " - - " (note the leading and trailing spaces).

EMG

[manuramos]

Yes it's true. I don't know why. It seems a bug.

[manuramos]

Enrico, I'm remembering, tree years ago,more or less, I modified some methods of TGET class, and I released leading spaces. It's running OK.

[Enrico Maria Giordano]

Enrico, I'm remembering, tree years ago,more or less, I modified some methods of TGET class, and I released leading spaces. It's running OK.

Sorry, I don't understand. Are you saying that you leaved or removed the leading spaces?

EMG

[manuramos]

Excuse my english. I removed it.

[Enrico Maria Giordano]

Ah, ok.

EMG

[Antonio Linares]

Enrico,

I guess the right code is ... .or. cText == " - -" without using AllTrim().

The other expressions seem fine.

[Enrico Maria Giordano]

Enrico,

I guess the right code is ... .or. cText == " - -" without using AllTrim().

The other expressions seem fine.

I think not. If cText is an empty date it will be " - - " or " / / " (note the trailing space) and the exact comparison (==) will fail. Or am I wrong?

EMG

[Antonio Linares]

Enrico,

Please notice that there are three spaces in front: " - -"

It looks as a picture for US phone numbers.

[Enrico Maria Giordano]

Enrico,

Please notice that there are three spaces in front: " - -"

It looks as a picture for US phone numbers.

Ok, right. But what about ... .or. cText == " / /"?

EMG

[Antonio Linares]

Enrico,

> cText == " / /"

It looks as an empty date (please notice that AllTrim() was not needed). There are two spaces before the first "/" and none after the last "/".

That seems to be the return from GetWindowText() when the date is empty. (edit: not sure about this, as a space may be typed after)

[Enrico Maria Giordano]

Enrico,

> cText == " / /"

It looks as an empty date (please notice that AllTrim() was not needed). There are two spaces before the first "/" and none after the last "/".

That seems to be the return from GetWindowText() when the date is empty.

Are you sure that GetWindowText() returns " / /" without the two trailing spaces? If yes then ok.

EMG

[Antonio Linares]

Enrico,

The problem is that if a PICTURE is used that has a "/" or a "-" in the front, then the code will be wrong, as ::nPos should not be set to 1.

This may be the right code:

Code: Select all  Expand view

      elseif Empty( cText ) .or. RTrim( cText ) == "  /  /" .or. ;
         AllTrim( cText ) == "0" .or. ;
         RTrim( cText ) == "   -  -"


What do you think ?