Checked menuitem

[AlexSchaft]

Hi,

Why do menu items with checks appear with the check in a border?



Also, is there a way to "bullet" a menu item, like the view menu in windows explorer?

Alex

[Antonio Linares]

Alex,

Please comment out this line in source\winapi\menus.c line 295:

Code: Select all  Expand view

           if( lpdis->itemState & ODS_CHECKED )
           {
              HBITMAP hBmp = LoadBitmap( 0, MAKEINTRESOURCE( OBM_CHECK ) );

              if( ! ( lpdis->itemState & ODS_SELECTED ) )
                 DrawGrayed( lpdis->hDC, hBmp, lpdis->rcItem.top + 1,
                             lpdis->rcItem.left + 1 );
              else
                 DrawMasked( lpdis->hDC, hBmp, lpdis->rcItem.top + 1,
                             lpdis->rcItem.left + 1 );
              DeleteObject( hBmp );
              // WindowInset( lpdis->hDC, &rct );   HERE!
           }


We have to implement the bullet option.

[AlexSchaft]

Hi,

What #defines do I need to compile this? Compiling fails using Xhb

Tried WIN32

Alex

[Antonio Linares]

Alex,

We email you the modified library for your review, thanks.

[Enrico Maria Giordano]

It seems that there is still a light grey background under the check sign.

EMG

[Antonio Linares]

Enrico,

Please try this:

Code: Select all  Expand view

           if( lpdis->itemState & ODS_CHECKED )
           {
              HBITMAP hBmp = LoadBitmap( 0, MAKEINTRESOURCE( OBM_CHECK ) );

              DrawMasked( lpdis->hDC, hBmp, lpdis->rcItem.top + 1,
                                lpdis->rcItem.left + 1 );
              DeleteObject( hBmp );
           }


[Enrico Maria Giordano]

Can you send me the new lib, please?

EMG

[AlexSchaft]

Hi,

I've gotten menus.c to compile, and highlighted menu items are ok, but unhighlighted items still have the gray background?

[Antonio Linares]

Alex,

Are you still using DrawMasked() ? If yes, does your bitmap has the transparent color at pixel 0, 0 ?

Please post a screenshot of the bitmap and how it looks in the menu. Thanks

[AlexSchaft]

Hi,

This is the gray background of unselected menu items, as below

[Antonio Linares]

Alex,

Are those menuitems "checked" ?

[AlexSchaft]

Yes, they are

[Antonio Linares]

Alex,

Please make this change in your menus.c:

Code: Select all  Expand view

           if( lpdis->itemState & ODS_CHECKED )
           {
              HBITMAP hBmp = LoadBitmap( 0, MAKEINTRESOURCE( OBM_CHECK ) );

              DrawMasked( lpdis->hDC, hBmp, lpdis->rcItem.top + 1,
                          lpdis->rcItem.left + 1 );
              DeleteObject( hBmp );
           }


[AlexSchaft]

Did that change from your earlier post.

Selected items are ok, unselected are not

[Antonio Linares]

Alex,

You are using white as the menu color, please select another menu color and check if that makes a difference, thanks