Warning W8075

[ukservice]

Hello,

I get the following waring when I compile:

Warning W8075 c:\\myapp\\test\\FTP.PRG 645: Suspicious pointer conversion in function HB_FUN_INTERNETREADFILE

Line is:

Code: Select all  Expand view

BOOL lSuccess = InternetReadFile( ( HINTERNET ) hb_parnl( 1 ), hb_parc( 2 ), hb_parclen( 2 ), &nBytesRead );

And whole function is:

Code: Select all  Expand view

HB_FUNC( INTERNETREADFILE )
{
    DWORD nBytesRead;

    BOOL lSuccess = InternetReadFile( ( HINTERNET ) hb_parnl( 1 ), hb_parc( 2 ), hb_parclen( 2 ), &nBytesRead );

    if ( !lSuccess )
        hb_retnl( -1 );
    else
        hb_retnl( nBytesRead );
}

What is wrong?.

Thank you very much!!.

[Daniel Garcia-Gil]

Hello

the 2nd parameter is a output buffer that receives the data.

hb_parc() is a pointer to constant char, we can not change this,
should allocate memory to use like output buffer
1) send the variable by reference and return the length or
2) returning the output buffer

please test both case ( i didn't test )

Code: Select all  Expand view

#pragma BEGINDUMP
#include <hbapi.h>
#include <windows.h>
#include <wininet.h>

HB_FUNC( INTERNETREADFILE1  )
{
    DWORD nBytesRead;
    char * pOut = ( char * ) hb_xgrab( hb_parnl( 2 ) );

    BOOL lSuccess = InternetReadFile( ( HINTERNET ) hb_parnl( 1 ),
                                      pOut, hb_parnl( 2 ), &nBytesRead );

    if ( !lSuccess )
        hb_ret();
    else
        hb_retc( pOut );
}

HB_FUNC( INTERNETREADFILE2  )
{
    DWORD nBytesRead;
    char * pOut = ( char * ) hb_xgrab( hb_parclen( 2 ) );

    BOOL lSuccess = InternetReadFile( ( HINTERNET ) hb_parnl( 1 ),
                                      pOut, hb_parclen( 2 ), &nBytesRead );

    if ( !lSuccess )    
        hb_retnl( -1 );
    else
    {
        hb_storc( pOut, 2 );
        hb_xfree( pOut );
        hb_retnl( nBytesRead );
    }
}

#pragma ENDDUMP
 

[ukservice]

Thank you four quick support.

My code works despite the warning. I got this warning when I move from Harbour 1.x to Harbour 2.0

Also, I get the same warning in other code:

Warning W8075 update.prg 382: Suspicious pointer conversion in function HB_FUN_FILETIMES

Code: Select all  Expand view

LPSTR cFileName = hb_parc( 1 ) ;

 

Warning W8075 update.prg 478: Suspicious pointer conversion in function HB_FUN_RESTOFILE

Code: Select all  Expand view

WriteFile(hFile,pRes,size,&bytesWritten,NULL);

So I do not understand the problem.

What could happend?.

Thank you.

[Daniel Garcia-Gil]

Hello

Code: Select all  Expand view

LPSTR cFileName = ( LPSTR ) hb_parc( 1 ) ;

what is the definitions of hFile, pRes, size, &bytesWritten ??

[ukservice]

Hello

This is the complete function:

Code: Select all  Expand view

HB_FUNC( RESTOFILE )
{
   HRSRC res=FindResource(NULL,"ACTVER",RT_RCDATA);
   LPDWORD bytesWritten;
   int size=SizeofResource(NULL,res);
   HGLOBAL hRes=LoadResource(NULL,res);
   unsigned char *pRes=(unsigned char *)LockResource(hRes);
   HANDLE hFile=CreateFile("ACTVER.EXE",GENERIC_WRITE,0,NULL,CREATE_ALWAYS,0,NULL);
   WriteFile(hFile,pRes,size,&bytesWritten,NULL);
   CloseHandle(hFile);
}
 

Thank you.

[Daniel Garcia-Gil]

Hello

should be

Code: Select all  Expand view

DWORD bytesWritten;

[ukservice]

Daniel,

Thank you very much for so quick support!!. Now warnings are off.

Those changes refer to Bielsys article about updating software via FTP.

What book do you recomend me to learn C in Harbour?.

Thanks again.

[Daniel Garcia-Gil]

Hello

look my firm
( our best documentation is the source code )

i learned C reading the harbour source code

[Enrico Maria Giordano]

Code: Select all  Expand view

BOOL lSuccess = InternetReadFile( ( HINTERNET ) hb_parnl( 1 ), hb_parc( 2 ), hb_parclen( 2 ), &nBytesRead );

Code: Select all  Expand view

BOOL lSuccess = InternetReadFile( ( HINTERNET ) hb_parnl( 1 ), ( LPVOID ) hb_parc( 2 ), hb_parclen( 2 ), &nBytesRead );

Please note that you have to pass an existing buffer by reference to the function:

Code: Select all  Expand view

LOCAL cData := SPACE( 1024 )

...

nRead = INTERNETREADFILE( hSource, @cData )

You don't need to allocate the buffer in the C function but you can if you prefer doing so.

EMG

[ukservice]

Mr Enrico,

Thank you. It works perfect.

By the way, what books do you recomend me to learn C?.

Thank you again.

[Enrico Maria Giordano]

I start learning C in the middle of '80th using the "bible" Kernighan & Ritchie.

EMG

[ukservice]

Thank you again.

But is there something recent for Harbour?.

I am afraid I won´t understand Harbour sources as Daniel suggested to me.

[nageswaragunupudi]

I start learning C in the middle of '80th using the "bible" Kernighan & Ritchie.

EMG

Me too.

Ritchie is the creator of C language.

This book is available for download as e-book.
http://www.inf.unideb.hu/grafika/eng/rt ... uage_C.pdf

Very easy to understand even for a dull-head like me.

[ukservice]

Thank you Mr. Rao.

You are a Master of FWH