Problem with aGetFiles()

[Taavi]

Hello,
there seems to be a problem with new function aGetFiles() introduced in FWH 10.9.
At some file count (or maybe return string length) function cgetfile() call used in this function returns just emtpy string. User reported problem on XP, tested and problem exists also on Windows 7/64.

Taavi.

[Antonio Linares]

Taavi,

What parameters are you supplying to the function ?

[Taavi]

Hi,
I tested with code:

if len(afailid:=agetfiles('Testfiles | *.dbf' ,'Please select files.'))==0
teade('Import katkestatud.')
return
endif

aeval(afailid,{|x| alert(x) })

Works when selecting 10 ..15 files, with 20 files selected returns empty array. Filenames with path are approx. 50 characters each.

Taavi.

[Antonio Linares]

Taavi,

In function cGetFile() we use this amount of memory to be allocated: (5128)

pFile = ( LPSTR ) _xgrab( ( dwFlags & OFN_ALLOWMULTISELECT ) ? 5128 : 256 );

Please increase it (double or triple) and try it again, thanks

[Taavi]

Hi, tryed with

pFile = ( LPSTR ) hb_xgrab( ( dwFlags & OFN_ALLOWMULTISELECT ) ? 15384 : 256 );

No changes.
Taavi

Taavi,

In function cGetFile() we use this amount of memory to be allocated: (5128)

pFile = ( LPSTR ) _xgrab( ( dwFlags & OFN_ALLOWMULTISELECT ) ? 5128 : 256 );

Please increase it (double or triple) and try it again, thanks

[Daniel Garcia-Gil]

Taavi

please change this value too

Code: Select all  Expand view

ofn.nMaxFile        = ( dwFlags & OFN_ALLOWMULTISELECT ) ? 15384 : 256;

[Taavi]

Thanks, it worked now.

shouldnt't we also change number here?

if ( dwFlags & OFN_ALLOWMULTISELECT ) hb_retclen( pFile, 5128 );

Taavi

please change this value too

Code: Select all  Expand view

ofn.nMaxFile        = ( dwFlags & OFN_ALLOWMULTISELECT ) ? 15384 : 256;

[James Bott]

I suggest that the value 5128 could be made into a manifest constant so it only has to be changed in one place in the future.

Regards,
James

[Antonio Linares]

James,

Fixed for next build using a define constant