A little correction on Get Action Bitmap

[fraxzi]

Dear All,

Anyone using Get with Action and Bitmap Clause..

Before:



minor coding:

Code: Select all  Expand view

AEval( aGetObjs, {|a| IF(Upper(a:Classname()) == 'TGET',;
                      IF( a:oBtn <> Nil, ( a:oBtn:nWidth -= 1, a:oBtn:nHeight -= 1 ),Nil) ,Nil) })

Results:


The action bitmap is now visually better.


I hope this will be fix in v10.6


Regards,
Frances

[Antonio Linares]

Frances,

Please test samples\GetBtn.prg and post here a screenshot of it, thanks

[fraxzi]

Dear Mr. Antonio,

I tried/read "getbtn.prg" but declaration is diff not redefined.

Code: Select all  Expand view

#include "FiveWin.ch"

function Main()

   local oWnd, cTest := "Hello world!"

   DEFINE WINDOW oWnd COLOR "N/W*"

   @ 2, 2 GET cTest SIZE 110, 22 ;
      ACTION MsgInfo( "click" ) BITMAP "..\bitmaps\16x16\find.bmp"

   ACTIVATE WINDOW oWnd

return nil

Screenshot:



my redefined action Get:

Code: Select all  Expand view

REDEFINE GET oGet VAR cVar;
         ID 1015 OF oDlg UPDATE;
         BITMAP 'client16';
         ACTION msginfo('here')

RC:

Code: Select all  Expand view

...
  CONTROL "",1015,"Edit",WS_CHILDWINDOW|WS_VISIBLE|WS_TABSTOP,78,75,124,12,WS_EX_CLIENTEDGE
...

Maybe there's a difference between redefine and command @..


Regards,
Frances

[Antonio Linares]

Frances,

In source\classes\TGet.prg please modify these lines:

Code: Select all  Expand view

            ::oBtn := TButtonBmp():New( 0, ::nWidth - nBmpWidth - If( ::lSpinner, 20, 4 ),, Self, {|| Eval( oThis:bAction, oThis ) }, ;
            nBmpWidth, ::nHeight - 4,,,,.t.,,,,,,,::cBmpName )
 

Use - 5 instead of - 4 and please check the results, thanks

[Antonio Linares]

This may be a better implementation:

Code: Select all  Expand view

::oBtn := TButtonBmp():New( 0, ::nWidth - nBmpWidth - If( ::lSpinner, 20, 4 ),, Self, {|| Eval( oThis:bAction, oThis ) }, ;
            nBmpWidth, ::nHeight - If( ::oWnd:IsKindOf( "TDIALOG" ) .and. ! Empty( ::oWnd:cResName ), 5, 4 ),,,,.t.,,,,,,,::cBmpName )