xbrowse array autosort problem

[Richard Chidiak]

Hello

I need to sort a column of a xbrowse "at startup" as descending, I am browsing an array

The bitmap (for ascending, descending) is showing "descending" for the column but the column is not sorted

This is the code below ,

Thanks for the help,

Code: Select all  Expand view

REDEFINE XBROWSE oBrw ID 201 OF ODLG ;
         COLUMNS 2,10,5,3,4,7,11,12,13 ;
         HEADERS "Date" + CRLF + "Facture", "Fournisseur","N°" + CRLF + "Facture","Date" + CRLF + "Echéance","Date" + CRLF + "Paiement","Total" + CRLF + "TTC","Total" + CRLF + "Acomptes","Solde","Motif";
         FOOTERS ;
         FONT aFont ;
         COLORS {|| { CLR_BLUE, CLR_WHITE } } ;
         colsizes asize ;
         array TVISU lines AUTOSORT

oBrw:aCols[01]:cOrder := 'D'   // this is not working

 

[nageswaragunupudi]

Instead of

Code: Select all  Expand view

oBrw:aCols[01]:cOrder := 'D'   // this is not working

Remove the above line and Substitute with

Code: Select all  Expand view

oBrw:aCols[01]:SetOrder()  // This works
 

[Richard Chidiak]

Thank you Mr Rao

in order to have it descending , the following is needed also

oBrw:aCols[01]:CSORTOrder := 'D'

[nageswaragunupudi]

Thank you Mr Rao

in order to have it descending , the following is needed also

oBrw:aCols[01]:CSORTOrder := 'D'

NO PLEASE.

The solution I provided works correctly and that is the only way.

oCol:cSortOrder ( in case of arrays ) is the array element number on which to sort but not 'D' or 'A'.

oCol:cSort holds if it is "A" or "D", after it sorts in ascending or descending order. Let xBrowse handle this internally and let us not confuse xBrowse by handling this directly.

oCol:SetOrder() sorts the column, switching ascending to descending and vice-versa. When the browse is defined with AUTOSORT, the browse has already sorted on ascending order of first column.
When we call aCols[1]:SetOrder(), it sorts in descending order because it is already sorted in the ascending order.

Adopting my solution will give you the result required by you and please do not touch cSortOrder or cSort.

[Richard Chidiak]

You are right sorting arrays confused me a bit ,

Can you please review the seekonarray function , in case of non sequential columns (like in my sample)

the following line will cause an error in this case, i have commented it as i always need to seek on upper values

if ! ::aCols[ nCol ]:lCaseSensitive // we get out of range in this case

Thank you for your help

Richard

[James Bott]

Adopting my solution will give you the result required by you and please do not touch cSortOrder or cSort.

This is why instance vars such as these should be READONLY or even HIDDEN--so we can't mess with them.

Regards,
James

[nageswaragunupudi]

You are right sorting arrays confused me a bit ,

Can you please review the seekonarray function , in case of non sequential columns (like in my sample)

the following line will cause an error in this case, i have commented it as i always need to seek on upper values

if ! ::aCols[ nCol ]:lCaseSensitive // we get out of range in this case

Thank you for your help

Richard

Mr. Richard
You are right.
For the time being, it is better to comment out this if .... and corresponding endif.

[Richard Chidiak]

Mr Rao , i already did

when browsing an empty array with autosort, it errors, the correct fix for this is in the method setarray

And again when a column has no header or ablank header (only in browsing arrays) , xbrowse shows a character for the header, i go around this by setting a non visible char for the header....

Thank you for your help,

Richard

Code: Select all  Expand view

//      if lAutoOrder
      if lAutoOrder .AND. ! Empty( aData ) // this line in replacement of the above
         if ValType( aData[ 1 ] ) == 'A'

            DEFAULT nColOrder := ::aCols[ 1 ]:nArrayCol

            AEval( ::aCols, {|oCol| oCol:cSortOrder := oCol:nArrayCol, ;
                            If( oCol:nArrayCol == nColOrder, ;
                                 (oCol:cOrder := 'D', oCol:SortArrayData() ), ;
                                 nil ) ;
                            } )
         else
            oCol:cOrder := 'D'
            oCol:cSortOrder := 1
            oCol:SortArrayData()
         endif
      endif
   endif

 

[nageswaragunupudi]

Mr Richard

when browsing an empty array with autosort, it errors, the correct fix for this is in the method setarray

You are right. This needs to be fixed.
Better fix seems to be

Code: Select all  Expand view

if Len( ::aCols ) > 1

And again when a column has no header or ablank header (only in browsing arrays) , xbrowse shows a character for the header, i go around this by setting a non visible char for the header....

If defining the browse in command mode, we may specify "" or " " in the HEADERS clause for the columns with blank headers.
Or after creating the browse, we may assign oCol:cHeader := '' or ' ' or nil

[Richard Chidiak]

Mr Rao

oBrwI:aCols[01]:SETORDER() is working as expected , in my case the column is reversed to descending mode and this is what i want

Nevertheless, adding a new entry to the array of the browse will place the entry at the end of the list (not where it should be), i issue a obrw:refresh(.t.)after adding the entry.

if i reset a oBrwI:aCols[01]:SETORDER() before the refresh , then the line is placed correctly

The problem is that the sort order is reversed to ascending in this case... any clue ?

Thank you for your help

Richard

[nageswaragunupudi]

Please do this after adding a new line:

Code: Select all  Expand view

WITH OBJECT oBrw:aCols[ 1 ]
   :cOrder := If( :cOrder == 'A', 'D', 'A' )
   :SetOrder()
END
oBrw:Refresh()
 

[Richard Chidiak]

thank you

Is there a way to know what was the column sorted by the user ?

I am using AUTOSORT and it could be any column, i need to refresh the "last sorted column"

[nageswaragunupudi]

Code: Select all  Expand view

nSortedCol := AScan( oBrw:aCols, { |o| !Empty( o:cOrder ) } )
oSortedCol := If( nSortedCol > 0, oBrw:aCols[ nSortedCol ], nil )

[Richard Chidiak]

that does the job, thank you

Don't you think this code should be included in the refresh method when browsing arrays with autosort ?

[nageswaragunupudi]

that does the job, thank you

Don't you think this code should be included in the refresh method when browsing arrays with autosort ?

Sorting an array does consume some time, small or more, depending on the array size. Resorting is necessary only when a Row is added, which is not always the case. In the life-cycle of a large software this may become necessary in less than fraction of the total refreshes. It is therefore desirable for the programmer to handle it.