xbrowse required bug fixes !

[Antonio Linares]

After testing the code that we have published here:
viewtopic.php?f=3&t=15935

we have detected some errors in Class TXBrowse that must be fixed:

1) Method End() has to be renamed as Destroy(). It was wrong. And finally call return Super:Destroy()

2) This code is needed in Method CreateButtons() before the @ ..., ... :

Code: Select all  Expand view

      if ::oBtnList != nil
         ::oBtnList:End()
      endif  
      if ::oBtnElip != nil
         ::oBtnElip:End()
      endif  
 

3) In function function TXBrows() the browse is not destroyed:

Code: Select all  Expand view

   if ValType( bChild ) == 'B'
      bXBr:End()
      bXBr := bChild
   endif
 

4) PalBmpFree() is not properly working. This function should be added:

Code: Select all  Expand view

function PalBmpFree( hBmp, hPal )

   DeleteObject( hBmp )
   DeleteObject( hPal )

return nil
 

[Otto]

Hello Antonio,

what version of xBrowse is affected ?
Thanks in advance
Otto

[Antonio Linares]

Otto,

The Method End(), that must be Destroy(), affects to all xbrowse versions.
The PalBmpFree() may also affect to all xbrowse versions.

The others two, can't say the exact version right now. Better look in your xbrowse.prg code for those sections. Thanks,

[Antonio Linares]

Another bug fixed:

Code: Select all  Expand view

METHOD End() CLASS TXBrwColumn

...

   for nFor := 1 to Len( ::aBitmaps )
      PalBmpFree( ::aBitmaps[ nFor, BITMAP_HANDLE ], ::aBitmaps[ nFor, BITMAP_PALETTE ] )
   next

return nil
 

[Patrizio]

Good

[Davide]

Antonio,
do you plan to release 9.06 before the month end ?
(I'd prefer having the bugfixes already included in the standard lib rather than including another obj)
Thanks,
Davide

[Antonio Linares]

Davide,

We are working hard to deliver 9.06 before end of this month.

But we can't promise it yet