Bug in Transparent Group

[nageswaragunupudi]

This is the sample showing the problem

Code: Select all  Expand view

#include 'fivewin.ch'

function Main()

   local oWnd

   DEFINE WINDOW oWnd COLOR CLR_WHITE,CLR_BLUE
   @ 20, 20 TO 200,400 PIXEL OF oWnd TRANSPARENT
   ACTIVATE WINDOW oWnd

return nil
 

This is the result:


Background of the DestkTop is visible through the Group.
Is this a bug or am I doing something wrong?

[Antonio Linares]

Rao,

Class TGroup uses a NULL brush for TRANSPARENT mode and the NULL brush does not work fine under all circunstances.

Please use this workaround which works better:

Code: Select all  Expand view

#include 'fivewin.ch'

function Main()

   local oWnd, oGrp

   DEFINE WINDOW oWnd COLOR CLR_WHITE, CLR_BLUE
   
   @ 20, 20 GROUP oGrp TO 200,400 PIXEL OF oWnd // TRANSPARENT
   
   oGrp:SetBrush( oWnd:oBrush )
   
   ACTIVATE WINDOW oWnd

return nil
 

[nageswaragunupudi]

Mr. Antonio

Thanks.

But when we use image or gradient brush for the window, the background inside the group does not match the background of the window.

The following solution appears to be working ( for windows ), both when resized and brush is changed at runtime.

Code: Select all  Expand view

  oGrp:bEraseBkGnd := { |hDC| SetBrushOrgEx( hDC, -oGrp:nLeft, -oGrp:nTop ), ;
        FillRect( hDC, GetClientRect( oGrp:hWnd ), oGrp:oWnd:oBrush:hBrush ) }
 

Can TGroup include similar code?

[Antonio Linares]

Rao,

Included in FWH 9.12 this way:

Code: Select all  Expand view

METHOD EraseBkGnd( hDC ) CLASS TGroup

   if ! Empty( ::bEraseBkGnd )
      return Eval( ::bEraseBkGnd, hDC )
   endif

  if ::lTransparent
     if ! Empty( ::oWnd:oBrush:hBitmap )
        SetBrushOrgEx( hDC, nBmpWidth( ::oWnd:oBrush:hBitmap ) - ::nLeft, nBmpHeight( ::oWnd:oBrush:hBitmap ) - ::nTop )
     endif  
     FillRect( hDC, GetClientRect( ::hWnd ), ::oWnd:oBrush:hBrush )
  else
     FillRect( hDC, GetClientRect( ::hWnd ), ::oBrush:hBrush )
  endif
 
return 0  
 

Thanks!

[Horizon]

Antonio,

Can you try this sample using DIALOG with new EraseBkGnd and without.

Thanks,

Code: Select all  Expand view

#include 'fivewin.ch'

function Main()

   local oWnd, cGet := SPACE(15)

   DEFINE DIALOG oWnd COLOR CLR_WHITE,CLR_BLUE SIZE 600,400
   
   @ 20, 20 TO 100,200 PIXEL OF oWnd TRANSPARENT
     
   @ 60, 20 TO 100,200 PIXEL OF oWnd TRANSPARENT
     
   ACTIVATE DIALOG oWnd CENTER

return nil

[Horizon]

Hi,

If I change the method like below it works in dialogs like windows. I don't know it is exactly true.

Code: Select all  Expand view

METHOD EraseBkGnd( hDC ) CLASS TGroup

   if ! Empty( ::bEraseBkGnd )
      return Eval( ::bEraseBkGnd, hDC )
   endif

  if ::lTransparent
     if ! Empty( ::oWnd:oBrush:hBitmap )
        SetBrushOrgEx( hDC, nBmpWidth( ::oWnd:oBrush:hBitmap ) - ::nLeft, nBmpHeight( ::oWnd:oBrush:hBitmap ) - ::nTop )
     endif  
     if UPPER(::oWnd:ClassName())="TWINDOW"     //added
            FillRect( hDC, GetClientRect( ::hWnd ), ::oWnd:oBrush:hBrush )
     endif //added
  else
     FillRect( hDC, GetClientRect( ::hWnd ), ::oBrush:hBrush )
  endif
 
return 0

[Antonio Linares]

Hakan,

Your example works fine here on Windows 7 with the new EraseBkGnd() code:

[Horizon]

Antonio,

You mean it works without any modification. I also use W7. When my example run it show like below.



When my sample lost focus, it is ok.

[nageswaragunupudi]

On dialogs the previous code also works.

As I said earlier, the modification was necessary only for groups on windows.

[Horizon]

Hi,

I have no problem with fwh 9.11's TGroup class in dialogs or my modified 9.12 TGroup Class.

Thanks,

[Horizon]

Antonio ?

[Antonio Linares]

Hakan,

With FWH 9.12 and the posted example, here it works fine on Windows 7.

Please post an example if you have a wrong behavior, thanks

[Horizon]

Hi Antonio,

Unfortunately, my previous example has the same error in my computer. I have the latest fwh 9.12 (I think).

I don't want to change TGroup class everytime that I downloaded fwh. How Can I solve my problem.

[Antonio Linares]

Hakan,

There is a FWH 9.12 31 December build. Please download it and test it.

If there is something wrong, please provide an example to reproduce it, thanks

[Horizon]

Antonio,

Result is the same. my sample is below.

Code: Select all  Expand view

#include 'fivewin.ch'


function Main()

   local oWnd

   DEFINE DIALOG oWnd COLOR CLR_WHITE,CLR_BLUE SIZE 600,400
   
   @ 20, 20 TO 100,200 PIXEL OF oWnd TRANSPARENT
     
   @ 60, 20 TO 100,200 PIXEL OF oWnd TRANSPARENT
     
   ACTIVATE DIALOG oWnd CENTER

return nil

First run of app, it has the same error, but when i click outside of the dialog it is OK.