Colored combobox on Windows 7

[Enrico Maria Giordano]

The following sample works fine on XP but not on Windows 7 (it doesn't change the color of the combobox on W7):

Code: Select all  Expand view

#include "Fivewin.ch"


FUNCTION MAIN()

    LOCAL oDlg

    LOCAL oCbx, cVar := ""

    DEFINE DIALOG oDlg

    @ 1, 1 COMBOBOX oCbx VAR cVar;
           ITEMS { "1", "2", "3" }

    @ 3, 1 BUTTON "Change color";
           ACTION ( oCbx:SetColor( , CLR_HRED ),;
                    oCbx:Refresh() )

    ACTIVATE DIALOG oDlg;
             CENTER

    RETURN NIL

EMG

[Antonio Linares]

Dear Enrico,

It is working fine here on W7 ultimate 32:

[Enrico Maria Giordano]

I forgot to mention that the problem is only for themed apps. Please retry using the theme resource.

EMG

[James Bott]

I would seem that themes should override color settings. How else can they work? How would a theme know which color settings to override and which not to?

James

[Enrico Maria Giordano]

On XP the comboboxes are correctly colored.

EMG

[James Bott]

>On XP the comboboxes are correctly colored.

OK, but one wonders is that a bug, or by design? I still can't figure out how the theme knows which colors to change and which not to.

James

[Enrico Maria Giordano]

The other controls get correctly colored. Only the comboboxes are not colored.

EMG

[James Bott]

I note the both TGet and Tcombobox inherit from TControl which inherits from TWindow. Only TWindow has a setColor() method so they all use this method. This will make it more difficult to figure out why TCombobox is not working the same as TGet.

I am making the assumption that TGet does display the colors set using setColor. Is that correct?

James

[Enrico Maria Giordano]

Yes.

EMG

[James Bott]

There is a ctlColor() method in TWindow. It does not exist in TControl or TGet. However, there is a ctlColor() method in TCombobox so I think this is where the problem is.

James

[James Bott]

I don't have Win 7 here for testing, but you could try either commenting out the CtlColor() method in TCombobox or just calling the parent method instead.

Method CtlColor(...) Class TCombobox
return super:ctlColor(...)

If the color is then properly set, then this method is the problem.

James

[Enrico Maria Giordano]

Tried. No change.

EMG

[Antonio Linares]

Dear Enrico,

Using themes, the dropdown list gets properly colored:



The combobox bar is painted by the Windows themes engine, so we should not change that, unless I am wrong

[Enrico Maria Giordano]

On XP the edit parts of the comboboxes get correctly colored.

EMG

[Antonio Linares]

Dear Enrico,

In your example, the combobox is not editable (does not contain a GET).