Bug in ADrives() [Fixed]

[Enrico Maria Giordano]

With latest W10 update the function ADrives() is no longer working. To fix the problem, please replace

Code: Select all | Expand

FILE( CHR( i ) + ":\NUL" )

with

Code: Select all | Expand

ISDISK( CHR( i ) )

Hope ISDISK() is available in Harbour too.

EMG

[Antonio Linares]

Enrico,

I just tested:

Code: Select all | Expand

#include "FiveWin.ch"

function Main()

   XBrowser( ADrives() )
   
return nil

And it is working fine with Windows 10 Pro, version 1703, OSBuild 15063.138

What Windows 10 version are you using ?

[Enrico Maria Giordano]

Enrico,

I just tested:

Code: Select all | Expand

#include "FiveWin.ch"

function Main()

   XBrowser( ADrives() )
   
return nil

And it is working fine with Windows 10 Pro, version 1703, OSBuild 15063.138

What do you get? I get all the drives from C to Z after latest Windows update.

What Windows 10 version are you using ?

Latest official: Windows 10 Pro 1607 14393.1066

Anyway, I think that using a specific function like ISDISK() is better than the old trick with NUL, isn't it?

EMG

[Enrico Maria Giordano]

Now I have the same Windows version of yours (1703 build 15063.138) and the problem is not fixed.

EMG

[Antonio Linares]

What is exactly the problem ?

[Enrico Maria Giordano]

The problem is that ADrives() should return (and did before the recent Windows updates) only the existing drives in the system. In my PC it did return C, D AND E while now it wrongly returns all the drives from C to Z. Using ISDISK() instead of the NUL trick fixed the problem for me.

EMG

[Antonio Linares]

Could you post your code using ISDISK() ?

many thanks

[Enrico Maria Giordano]

Here it is:

Code: Select all | Expand

function ADrives( nType )  // Thanks to EMG

   local aDisk := {}
   local i

   DEFAULT nType := 0

   if nType = 0 .OR. nType = 1
      for i = ASC( "A" ) TO ASC( "B" )
          if ISDISKETTE( CHR( i ) + ":" )
             AADD( aDisk, CHR( i ) + ":" )
          endif
      next
   endif

   if nType = 0 .OR. nType = 2
      for i = ASC( "C" ) TO ASC( "Z" )
          if ISCDROM( CHR( i ) + ":" ) .OR. ISDISK( CHR( i ) )
             AADD( aDisk, CHR( i ) + ":" )
          endif
      next
   endif

return aDisk

EMG

[Antonio Linares]

many thanks

[Enrico Maria Giordano]

Antonio,

you forgot to fix this in the latest FWH build.

EMG

[Antonio Linares]

Enrico,

You are right

Already included for FWH 17.05

many thanks

[Enrico Maria Giordano]

Great, thank you!

EMG